the aforementioned bug and also some inconsistent behaviour when submitting a vector of potentials for certain electrode scales.
Both issues should be fixed now.
scale arg is recycled if it has unit length and length(potential) > 1. This saves the user some typing and makes the functions as.SHE() and from.SHE() easier to use.
The matching algorithm would fail for any electrode scale that had string in potentials.as.SHE()$conc.string that was not "saturated" (which happened to be the alkali metals). Fixed this issue by making the matching step-wise, and adding a few more checks for zero rows returned.
Goofed and declared dependency on photoec in previous commit. Fixed it by removing it and the non-exported function that used it.
Note to self: this package should not import any of my other packages.
Previous behaviour returned NAs for values that were already vs SHE. That issue now fixed. The fix included added SHE (zero at all temperatures) to as.SHE.data.
Taha Ahmed
TA
Taha Ahmed